Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Github workflow failed - Failed to build iOS app #87

Open
3 tasks done
ic-autosense-team opened this issue Nov 18, 2024 · 3 comments
Open
3 tasks done

Github workflow failed - Failed to build iOS app #87

ic-autosense-team opened this issue Nov 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ic-autosense-team
Copy link

Checklist

  • The issue can be reproduced in the attached sample application in the repository.
  • I have read the relevant SDK documentation and have not found a suitable solution or answer.
  • I agree to the terms within the SAP Code of Conduct.

Description

With gigya_flutter_plugin version 1.0.8, getting error failed to build iOS app

Swift Compiler Error (Xcode): Incorrect argument label in call (have 'url:callback:completionHandler:', expected 'url:callbackURLScheme:completionHandler:')
/Users/runner/work///ios/Pods/Gigya/GigyaSwift/Global/Providers/WebLogin/SsoLoginWrapper.swift:210:53

Swift Compiler Error (Xcode): Type 'String?' has no member 'customScheme'
/Users/runner/work///ios/Pods/Gigya/GigyaSwift/Global/Providers/WebLogin/SsoLoginWrapper.swift:210:75

Reproduction

  1. When we run Github worflow using Fastlane
  2. Workflow fails in iOS but works in Android.

Additional context

No response

SDK version

1.0.8

Android/iOS

iOS

@ic-autosense-team ic-autosense-team added the bug Something isn't working label Nov 18, 2024
@QRCharlie
Copy link

Hello, same problem both with 1.0.8 and 1.0.9.

Here's a possible solution: modify the Gigya POD file SsoLoginWrapper.swift at line 210 as follows

if #available(iOS 17.4, *) {
session = ASWebAuthenticationSession.init(url: url, callbackURLScheme: SsoLoginWrapper.callbackURLScheme, completionHandler: handler)
} else {
session = ASWebAuthenticationSession(url: url, callbackURLScheme: SsoLoginWrapper.callbackURLScheme, completionHandler: handler)
}

@ic-autosense-team
Copy link
Author

@QRCharlie Thank you for the fixes. However, we cannot change the Gigya POD file because if I edit it manually, the fix will be removed after running the Pod install command.

@QRCharlie
Copy link

@QRCharlie Thank you for the fixes. However, we cannot change the Gigya POD file because if I edit it manually, the fix will be removed after running the Pod install command.

Usually you run pod install once before working on your project. If you need to install/update your pods you will surely lose the changes to SsoLoginWrapper.swift.

So just make sure you modify SsoLoginWrapper.swift each time you install/update the pods.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants