Skip to content

Refactor ui5-calendar's onAfterRendering logic #10867

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
1 task done
vladitasev opened this issue Feb 14, 2025 · 2 comments · May be fixed by #11167
Open
1 task done

Refactor ui5-calendar's onAfterRendering logic #10867

vladitasev opened this issue Feb 14, 2025 · 2 comments · May be fixed by #11167
Assignees
Labels

Comments

@vladitasev
Copy link
Contributor

Feature Request Description

Currently, there is a mix of responsibilities in ui5-calendar regarding the knowledge of picker specifics and rendering the header buttons. This is manifested in onAfterRendering where the calendar needs to access the pickers in order to correctly render the header buttons.

Proposed Solution

Refactoring suggestion (but other options are welcome):

  • The "calendar header" part is no longer part of the calendar itself - each picker will render its own header (as the individual pickers have the knowledge how to render these buttons, not the calendar)
  • However, reuse the ".tsx" template for the header across all pickers (just the logic will be different)
  • When a button is pressed, the picker will fire an event to the calendar and the calendar will switch pickers, which in turn will render their own headers etc.

Proposed Alternatives

No response

Organization

No response

Additional Context

No response

Priority

Low

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@dobrinyonkov dobrinyonkov self-assigned this Feb 14, 2025
@dobrinyonkov
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-b,

could you please check this refactoring suggestion?

Kind Regards,
Dobrin

@tsanislavgatev
Copy link
Contributor

Moving this to Planning as it is an enhancement and refactoring.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants