Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

count() method is missing $quoteId parameter #10

Closed
redelschaap opened this issue Aug 25, 2015 · 1 comment
Closed

count() method is missing $quoteId parameter #10

redelschaap opened this issue Aug 25, 2015 · 1 comment
Assignees
Labels

Comments

@redelschaap
Copy link

The WebshopappApiResourceQuotesPaymentmethods::count() method is missing the $quoteId parameter. Without that parameter it's not possible to count the payment methods for that quote. Also the $params parameter seems mandatory, but I guess it's there for consistency / future features.

/**
 * @param int   $quoteId
 * @param array $params
 *
 * @return int
 * @throws WebshopappApiException
 */
public function count( $quoteId, $params = array() ) {
    return $this->client->read( 'quotes/' . $quoteId . '/paymentmethods/count', $params );
}
@jeroenvisser101
Copy link
Contributor

Hi @redelschaap, I'll ask @michielrensen to take a look at this when he's back from holiday! Thanks for submitting.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

No branches or pull requests

3 participants