Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Off-By-One error for CORNER_COLUMN and CORNER_ROW #7

Open
jcsmithhere opened this issue Jul 15, 2021 · 2 comments
Open

Off-By-One error for CORNER_COLUMN and CORNER_ROW #7

jcsmithhere opened this issue Jul 15, 2021 · 2 comments

Comments

@jcsmithhere
Copy link

I discovered that tess-cloud is using 0-based indexing for the reference corner column and row. The convention for the TESS instrument is 1-based indexing for the pixels.

This might be related to issue #4
@jcsmithhere jcsmithhere changed the title Off-by-One error for CORNER_COLUMN and CORNER_ROW Off-By-One error for CORNER_COLUMN and CORNER_ROW Jul 15, 2021
@barentsen
Copy link
Collaborator

Oh dear! Thanks for opening the issue Jeff. I expect to work on this today.

@barentsen barentsen mentioned this issue Jul 20, 2021
Merged
@barentsen
Copy link
Collaborator

barentsen commented Jul 21, 2021 •
edited
Loading

Thanks again @jcsmithhere. I went ahead and merged #8, which I believe fixes the issue.

Additional verification will be useful. The PR only includes a regression test for a single coordinate/sector so far.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barentsen @jcsmithhere