Skip to content

Stabilize verification of message types #38

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
SSheldon opened this issue Dec 6, 2015 · 2 comments
Closed

Stabilize verification of message types #38

SSheldon opened this issue Dec 6, 2015 · 2 comments
Milestone

Comments

@SSheldon
Copy link
Owner

SSheldon commented Dec 6, 2015

Verifying argument types for messages was added back with #10. It should remain behind a feature, but before it ships a couple things should be done:

  • What type should the error be? String isn't a very rust-y error type.
  • Should there be a public API for verifying these types? Or is panicking internally when they're incorrect sufficient?
  • The feature should be documented.
@SSheldon
Copy link
Owner Author

SSheldon commented Jan 4, 2016

A MessageError type was introduced in 6a6d714. It's currently just a light wrapper around a String, but it provides a level of abstraction so it can be improved in the future.

@SSheldon
Copy link
Owner Author

Added Message::verify_message in e187ba8. I think all that's left here is doing a final pass on the docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant