Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove QEMU and setup buildx to use the docker driver #1750

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Jul 10, 2023

Closes #1748

Changelog

  • Remove QEMU as we don't need to build image for multiple plaftorms
  • Use GH Action from the marketplace to setup buildx
  • Configure buildx to use the driver docker instead of docker-container (default)

Notes

  • Using the driver docker enables to build images that depends on local images (e.g. the -base:local images). However, we loose the ability to cache Docker layers in the CI workflow, which makes the workflow slower.

References

@tschaffter tschaffter self-assigned this Jul 10, 2023
@tschaffter tschaffter marked this pull request as ready for review July 10, 2023 20:50
@tschaffter tschaffter merged commit e5d5854 into main Jul 10, 2023
@tschaffter tschaffter deleted the remove-buildx branch July 10, 2023 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix images that depend on a base image
1 participant