-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Error 550 while removing directory #207
Comments
I think I have a similar problem. I have a cache folder, that is stored under a folder with the hash name (
The next upload has a similar structure, but with a different hash. The action correctly detects, that the outdated cache folder should be deleted, but throws a 550 error, when it tries to remove the folder, after all files inside it have been removed.
The folder is empty, but still exists on the server. Deleting it manually works just fine. Might there be a problem with deleting empty folders? |
This error is also being thrown in my case when I upgraded from version
|
there's an error with going up to the main directory |
Agreed. Same here. When it deletes the parent folder "Testfolder" it then complains is can't find "Testfolder/childfolder" and 550's |
Yep |
Same here. |
This may be a known fact, but... I was able to avoid the error by setting the "dangerous-clean-slate" option to "true". I think this is because the server's files are deleted first. |
Same error here. We are using FTP-Deploy-Action with Gatsby. It seems that it throws an error when trying to access (or delete?) an empty folder. Would be nice to have this fixed as right now we can't use automatic deployment because of this bug... |
I have fixed a similar issue that was happening to me in this fork, if you want to test this out. I'd be happy to help you if you have any issues with mine too. |
Thanks, I am actually having a similar issue using your version.
The interesting thing is that the folder
|
I had a similar issue so in version 4.2.1, I added one more try catch block around the remove folder method, so test that out. |
@Matt-17 it looks like this ticket got a bit off topic. I will work on the directory removal bug soon. But in your case I recommend your dynamically change which folder you're deploying to. The For example (note: untested code) name: Release Build
on:
push:
tags:
- 'v*.*.*' # note this line has changed. Anything with a tag following this pattern will run this deploy
jobs:
build:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: Set env
run: echo ::set-env name=RELEASE_VERSION::$(echo ${GITHUB_REF:10})
- name: FTP Deploy
uses: SamKirkland/FTP-Deploy-Action@4.1.0
with:
server: example.org
username: ${{secrets.FTPUSER}}
password: ${{secrets.FTPPASS}}
local-dir: /bin/Release/app.publish/
server-dir: Release/$RELEASE_VERSION/
log-level: verbose Example is a modified version of https://stackoverflow.com/questions/58177786/get-the-current-pushed-tag-in-github-actions |
Bug Description
I'm using this action to deploy current version of my app to an ftp. So one subdirectory is 1.0.0.1 then *.2 and so on. When the new version is compiled, the old folder does not exist, so this action tries to delete the old folder after removing every file. While removing the files works, the folder throws an error 550.
While this error is annoying I actually want to keep the old files. How do I achieve this or should I create a new issue?
My Action Config
My Action Log
The text was updated successfully, but these errors were encountered: