Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't show SLD Profile button for models without a profile #1897

Closed
smk78 opened this issue Aug 19, 2021 · 6 comments · Fixed by #2647
Closed

Don't show SLD Profile button for models without a profile #1897

smk78 opened this issue Aug 19, 2021 · 6 comments · Fixed by #2647
Labels
Critical High priority Defect Bug or undesirable behaviour Multiplicity Issue related to handling of multiplicity
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Aug 19, 2021

Using Release 5.0.4, clicking the Show SLD Profile button in the unified_power_rg model returns

ERROR: SLD profile calculation failed.

It works in the onion model...

@smk78 smk78 added the Defect Bug or undesirable behaviour label Aug 19, 2021
@butlerpd butlerpd added this to the SasView 5.0.5 milestone Aug 21, 2021
@rozyczko
Copy link
Member

model_info.profile attribute for this model is None, whereas it should be a method to calculate the profile.
This likely is a Sasmodels issue.

@smk78
Copy link
Contributor Author

smk78 commented Sep 1, 2021

Replaced by SasView/sasmodels#475

@smk78 smk78 closed this as completed Sep 1, 2021
@pkienzle pkienzle reopened this Nov 9, 2021
@pkienzle
Copy link
Contributor

pkienzle commented Nov 9, 2021

The program is correctly not showing the profile because it is not a shape-based model.

I'm changing the title to reflect that the profile button should be disabled or hidden in sasview for models that do not have an associated profile.

@pkienzle pkienzle changed the title Show SLD Profile not working in the unified_power_rg model Don't show SLD Profile button for models without a profile Nov 9, 2021
@butlerpd butlerpd modified the milestones: SasView 5.0.5, SasView 5.1.0 Jan 31, 2022
@butlerpd butlerpd added the Critical High priority label Jan 31, 2022
@butlerpd
Copy link
Member

I think this is related to the RPA issue SasView/sasmodels#396 (SLD also fails for RPA of course) in that it is misusing the "control" parameter. SLD seems to be attached to each model with a control parameter (and shown on the control parameter linked in the GUI interface). In other words all "multiplicity" models and only "multiplicity" models get the button.

We should decouple the show SLD from any parameter on the interface and provide that button only when a query to the model returns that an SLD function is available (hasSLD = True for example). Further that button should not be part of the parameter table IMO

At any rate this clearly cannot be done for 5.0.5 so moving it to 5.1

@rozyczko
Copy link
Member

rozyczko commented Feb 1, 2022

Not having the Show SLD button part of the table would simplify quite a lot of logic inside the table. I am for it.

@smk78 smk78 added the Multiplicity Issue related to handling of multiplicity label Sep 21, 2023
@butlerpd
Copy link
Member

butlerpd commented May 3, 2024

This should have closed with the merge of #2647. Doing it manually

@butlerpd butlerpd closed this as completed May 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Critical High priority Defect Bug or undesirable behaviour Multiplicity Issue related to handling of multiplicity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants