Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replotting 2D data re-opens all closed and cleared slicers #2752

Open
jack-rooks opened this issue Jan 19, 2024 · 2 comments · Fixed by #1919
Open

Replotting 2D data re-opens all closed and cleared slicers #2752

jack-rooks opened this issue Jan 19, 2024 · 2 comments · Fixed by #1919
Assignees
Labels
Being Tested When an issue is done but not ready to be closed. Defect Bug or undesirable behaviour Slicers Concerns slicer functionality

Comments

@jack-rooks
Copy link
Contributor

jack-rooks commented Jan 19, 2024

Describe the bug
Clicking the "Compute/Plot" button in the fit panel for 2D data, using a slicer, closing/clearing the slicer, and clicking "Compute/Plot" again re-opens all previously closed and cleared slicer plots (without the slicer overlay on the 2D plot) as well as producing a 1D circular average plot (even if the circular average was not previously performed).

Clicking the "Compute/Plot" button multiple times without using a slicer does not have this issue.

To Reproduce
Steps to reproduce the behavior:

  1. In the model fitter, select a model (cylinder was used), tick the "2D view" box, and press "Compute/Plot"
  2. Right click the 2D plot and open a slicer (either directly or through the slicer parameters menu)
  3. Close the slicer plot and right click the 2D plot to select the "Clear slicer" option
  4. Click "Compute/Plot" in the fit panel
  5. Observe reopened plots as well as a new 1D circular average plot

Expected behavior
Cleared and closed slicers do not reappear on replotting 2D data

SasView version (please complete the following information):

  • Version: main branch on 2024-01-19, but also present on 5.0.5

Operating system (please complete the following information):

  • OS: Windows 10
@jack-rooks jack-rooks added Defect Bug or undesirable behaviour Slicers Concerns slicer functionality labels Jan 19, 2024
@jack-rooks
Copy link
Contributor Author

The opening of the 1D circular average may be related to the sector slicer:

From SectorSlicer.py
new_plot.group_id = "2daverage" + self.data.name
Which indicates the ID for the sector slicer is erroneously the ID for the circular average. I will add this to a branch.

@jack-rooks jack-rooks self-assigned this Jan 19, 2024
@jack-rooks
Copy link
Contributor Author

Fixed by 2100_2726_2752_Slicer-bugfixes. Leaving this open for now as it has not been merged

@jack-rooks jack-rooks added the Being Tested When an issue is done but not ready to be closed. label Jan 21, 2024
@jack-rooks jack-rooks linked a pull request Jan 30, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Being Tested When an issue is done but not ready to be closed. Defect Bug or undesirable behaviour Slicers Concerns slicer functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant