[BUG] AttributeError: 'ProviderError' object has no attribute 'hostname'

[jyejare]

Tower has failed WF for which #145 was fixed and merged but now we see the following error with broker:

self = <broker.broker.VMBroker object at 0x7fcdca8e0370>
12:10:09  
12:10:09      @mp_decorator
12:10:09      def _checkout(self):
12:10:09          """checkout one or more VMs
12:10:09      
12:10:09          :return: List of Host objects
12:10:09          """
12:10:09          hosts = []
12:10:09          if not self._provider_actions:
12:10:09              raise self.BrokerError("Could not determine an appropriate provider")
12:10:09          for action in self._provider_actions.keys():
12:10:09              provider, method = PROVIDER_ACTIONS[action]
12:10:09              logger.info(f"Using provider ********provider.__name__} to checkout")
12:10:09              try:
12:10:09                  host = self._act(provider, method, checkout=True)
12:10:09                  logger.debug(f"host=********host}")
12:10:09              except exceptions.ProviderError as err:
12:10:09                  host = err
12:10:09              if host:
12:10:09                  hosts.append(host)
12:10:09  >               logger.info(f"********host.__class__.__name__}: ********host.hostname}")
12:10:09  E               AttributeError: 'ProviderError' object has no attribute 'hostname'
12:10:09  
12:10:09  ../../lib64/python3.8/site-packages/broker/broker.py:139: AttributeError

Please look into it !

[lpramuk]

Fixed by my #181 - to change a list which you are iterating over is really bad idea (removing ProviderErrors from hosts list)
As a result ProviderError is not removed from hosts list and later is treated as a regular host