Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix control for withCheckAll to be boolean #1699

Open
BoppLi opened this issue Aug 6, 2024 · 0 comments
Open

Fix control for withCheckAll to be boolean #1699

BoppLi opened this issue Aug 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working or not shown correctly dev Requires technical expertise

Comments

@BoppLi
Copy link
Contributor

BoppLi commented Aug 6, 2024

for the purpose of the storybook examples, it's enough to offer a boolean control for "withCheckAll".

Problem:

That does not solve the issue: the URL's "true" setting for withCheckAll is still ignored.
Image

Original Description:

https://storybook.onyx.schwarz/?path=/story/form-select--grouped-options&args=multiple:!true;open:!true;withSearch:!true;withCheckAll:!true
-> the link was created with
Image
but when you open the link/ reload you only get
Image
=> "withCheckAll" also has a combined type
Image

@BoppLi BoppLi self-assigned this Aug 6, 2024
@BoppLi BoppLi added bug Something isn't working or not shown correctly dev Requires technical expertise labels Aug 6, 2024
@BoppLi BoppLi added this to the Selection controls milestone Aug 6, 2024
@BoppLi BoppLi removed their assignment Aug 6, 2024
@MajaZarkova MajaZarkova self-assigned this Sep 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working or not shown correctly dev Requires technical expertise
Projects
Status: In Progress
Development

No branches or pull requests

4 participants