Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement OnyxSelect list description without bottom padding #1718

Open
2 of 3 tasks
MajaZarkova opened this issue Aug 7, 2024 · 0 comments
Open
2 of 3 tasks

Implement OnyxSelect list description without bottom padding #1718

MajaZarkova opened this issue Aug 7, 2024 · 0 comments
Labels
dev Requires technical expertise

Comments

@MajaZarkova
Copy link
Contributor

MajaZarkova commented Aug 7, 2024

Description

Figma

  • At the moment the component is implemented as it is designed in Figma. Meaning it has the white space (border) at the top and the bottom of the flyout.
  • Info from Jannick: He would like NOT to have the white space at the bottom if a list description is provided, but he was not able to concept it that way because of Figma restrictions.
  • In order to be always aligned with Figma and to avoid future questions and confusions we kept the white space for now.

This cannot be shown in Figma.

Confirmations

  • I have checked that there is not already a feature request for this feature.
  • I confirm that are no sensitive information included in this feature request. e.g. credentials, internal project details (for employees of the Schwarz Group) etc.

Acceptance criteria

  • The OnyxSelect doesn't show a (perceived) increased bottom-padding. The label itself is the padding.
@MajaZarkova MajaZarkova added the ux Requires UX/UI design label Aug 7, 2024
@MajaZarkova MajaZarkova added this to the Selection controls milestone Aug 7, 2024
@MajaZarkova MajaZarkova self-assigned this Aug 21, 2024
@JoCa96 JoCa96 added dev Requires technical expertise and removed ux Requires UX/UI design labels Nov 6, 2024
@JoCa96 JoCa96 changed the title Define final design for OnyxSelect with list description Implement OnyxSelect list description without bottom padding Nov 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dev Requires technical expertise
Projects
Status: Ready
Development

No branches or pull requests

2 participants