Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate Schwarz icon consumers to new icon library #1803

Open
1 of 23 tasks
larsrickert opened this issue Aug 28, 2024 · 4 comments
Open
1 of 23 tasks

Migrate Schwarz icon consumers to new icon library #1803

larsrickert opened this issue Aug 28, 2024 · 4 comments
Assignees
Labels
dev Requires technical expertise ux Requires UX/UI design

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Aug 28, 2024

@JoCa96 Split up between UX and DEV

Depends on

Why?

We want to have one unified icon library at Schwarz IT which is used by all UX designers (Figma) and developers.
Technically we already synched @sit-onyx/icons with the Single-Source-of-Truth Figma file linked below (see #939).

We now want to onboard/migrate all consumers of the current SIT icon library to use the new unified library, this includes:

  • STACKIT
  • ODJ
  • Twogo
  • CoreUI

For responsible contacts for the consumers above, you can refer to @larsrickert

So eventually, all designers will consume the Icon Library - UX Schwarz IT Figma library and all developers will consume the @sit-onyx/icons npm package.

Design

Icon Library - UX Schwarz IT

Acceptance criteria

  • onyx is migrated to use the new icon library
    • UX
    • DEV
  • STACKIT is migrated to use the new icon library
    • UX
    • DEV
  • ODJ is migrated to use the new icon library
    • UX
    • DEV
  • Twogo is migrated to use the new icon library
    • UX
    • DEV
  • CoreUI is migrated to use the new icon library
  • @schwarz-ux/icons repo is locked/deleted and npm package is either deprecated or updated to use the latest @sit-onyx/icons
  • all consumers are informed about the changes (e.g. via Teams)

Definition of Done

  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Namings are aligned with Figma

Approval

  • Deployed Docs
  • approved by onyx designer @jannick-ux
  • approved by onyx dev
  • approved by STACKIT
  • approved by ODJ
  • approved by Twogo
  • approved by CoreUI
@larsrickert larsrickert self-assigned this Aug 28, 2024
@larsrickert larsrickert added ux Requires UX/UI design dev Requires technical expertise cooperation Issues for projects in cooperative mode labels Aug 28, 2024
@mj-hof mj-hof removed the cooperation Issues for projects in cooperative mode label Aug 28, 2024
@mj-hof mj-hof added this to the Product improvements milestone Aug 28, 2024
@mj-hof
Copy link
Contributor

mj-hof commented Aug 29, 2024

Maybe a new or another nom package with a generic naming? @schwarzit/icons?

@mj-hof
Copy link
Contributor

mj-hof commented Aug 29, 2024

Check if we can display or link to an own url something like icons.schwarz (public) - is also a internal domain possible?

@larsrickert
Copy link
Collaborator Author

Maybe a new or another nom package with a generic naming? @schwarzit/icons?

The scope @schwarzit/* in npm was created by a former colleague at SIT, I am already in contact with @patrick246 to get access to it :) Imo @schwarzit/icons would be very nice!

@larsrickert
Copy link
Collaborator Author

Check if we can display or link to an own url something like icons.schwarz (public) - is also a internal domain possible?

@mj-hof I guess icons.schwarz should not be a problem, should I order it? Since its a public domain it may take some time before its ready for us. I would not make it internal since we also need it for onyx which is Open Source. Also internal domains are no longer allowed to use *.schwarz

@JoCa96 JoCa96 assigned JoCa96 and unassigned larsrickert Sep 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dev Requires technical expertise ux Requires UX/UI design
Projects
Status: New
Development

No branches or pull requests

3 participants