Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Specific FAQ about approvals for PRs automated system #15

Open
oxinabox opened this issue Aug 13, 2021 · 2 comments
Open

Specific FAQ about approvals for PRs automated system #15

oxinabox opened this issue Aug 13, 2021 · 2 comments

Comments

@oxinabox
Copy link
Contributor

It may be worth clarifying that if a PR is made by an automated system, e.g. CompatHelper.
Then that system is the "author" of the PR.
And thus it needs review only from someone with merge rights.
Even if it is a automated system that that person triggered directly/manually.
As long as the system itself is well tested and good.

@oxinabox
Copy link
Contributor Author

we should also include some statement about simple changes, like rebasing said PR,
or things that don't meaningfully change the code.

@ChrisRackauckas
Copy link
Member

agreed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants