Clarify whether amending commits / force-push is discuraged

[simeonschaub]

Guidance on contributing PRs says:

You should not squash down commits while review is still on-going.

• Squashing commits prevents the reviewer being able to see what commits are added since the last review.

It is not quite clear to me, whether this includes amending commits and then force-pushing. This is probably something that should be discouraged for non-trivial changes, but IMHO amending makes sense, if you realize right away that you made a dumb mistake and want to push a quick fix. Is that something that should be added? Do people have different opinions on this?

[oxinabox]

there is probably a way to rephrase it.

Would it be clearer to say:

try to avoid rewriting history (rebase, squash, filter-branch) such that commits that have been reviewed are removed from the history prior to the PR being approved, as this makes it hard to see what changes have been made since the last review.

Basically its fine to go and ammend your last commit that you pushed 3 minutes ago if you spot a typo etc.
But its annoying if a commit with comments on it just vanishes. (I think github handles that better now than it used to)
And its especially annoying if all history becomes a single commit and the reviewer can't see what was added to fix a problem they pointed out

[simeonschaub]

That sounds reasonable to me.