Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing wasm-opt when build the wasm package #4240

Closed
FirelightFlagboy opened this issue Mar 16, 2023 · 4 comments
Closed

Missing wasm-opt when build the wasm package #4240

FirelightFlagboy opened this issue Mar 16, 2023 · 4 comments
Assignees
Labels
A-Client Area: Parsec desktop application C-Bug Issue related to a bug good first issue Good for newcomers

Comments

@FirelightFlagboy
Copy link
Contributor

FirelightFlagboy commented Mar 16, 2023

For example when build the libparsec web lib in the CI (during web tests -> test e2e) https://github.com/Scille/parsec-cloud/actions/runs/4434681006/jobs/7780911345

We have this error (I can replicate this error on my side 😄).

Error: failed to execute `wasm-opt`: exited with signal: 11 (core dumped)
  full command: "/home/runner/.cache/.wasm-pack/wasm-opt-4d7a65327e9363b7/wasm-opt" "/home/runner/work/parsec-cloud/parsec-cloud/oxidation/bindings/web/pkg/index_bg.wasm" "-o" "/home/runner/work/parsec-cloud/parsec-cloud/oxidation/bindings/web/pkg/index_bg.wasm-opt.wasm" "-O"
To disable `wasm-opt`, add `wasm-opt = false` to your package metadata in your `Cargo.toml`.

To resolve this, either we install wasm-opt or we disable it.

@FirelightFlagboy FirelightFlagboy added C-Bug Issue related to a bug A-Client Area: Parsec desktop application labels Mar 16, 2023
@touilleMan
Copy link
Member

can you provide more context ? where this error message comes from ?

@FirelightFlagboy
Copy link
Contributor Author

I've added more context

@FirelightFlagboy
Copy link
Contributor Author

I have taken a more in depth view of this issue.

The problem is on the wasm-pack side, it should install wasm-opt on it's own.

But with the current version we use 10.3 It fail to do do.

wasm-pack have release the version 11.0 but it segfault on my side If I install it via npm.

But I've manage to make it work if I install via cargo install wasm-pack --no-default-features.

see: rustwasm/wasm-pack#1186 (comment)

@FirelightFlagboy FirelightFlagboy added the good first issue Good for newcomers label Mar 29, 2023
@FirelightFlagboy FirelightFlagboy self-assigned this Apr 7, 2023
@FirelightFlagboy
Copy link
Contributor Author

I've tested if the issue is still present on e2b3cbd, and good news :)

That's resolved with wasm-pack@0.11

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-Client Area: Parsec desktop application C-Bug Issue related to a bug good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants