Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[🐛 | Bug]: sign_windows_releases pagination #9824

Open
Landeers opened this issue Feb 26, 2025 · 0 comments
Open

[🐛 | Bug]: sign_windows_releases pagination #9824

Landeers opened this issue Feb 26, 2025 · 0 comments
Labels
B-Triage Blocker: The issue is awaiting triage C-Bug Issue related to a bug

Comments

@Landeers
Copy link
Contributor

Parsec version tested on:

3.3.0

Platforms tested on:

Windows

Bug description:

In get_artifacts function, we only get first 100 results. So if target is after, the script fails.
url = f"{base_url}/actions/artifacts?per_page=100"

We have to manage pagination, adding &page=x because we can not increase per_page, 100 is max (we can write more, but only first 100 results are returned).

Relevant output:

C:\Users\jerom\sign-releases>python sign_windows_release.py cli --version v3.3.0
Traceback (most recent call last):
  File "C:\Users\jerom\sign-releases\sign_windows_release.py", line 324, in <module>
    sign_cli(version, workdir)
  File "C:\Users\jerom\sign-releases\sign_windows_release.py", line 185, in sign_cli
    artifact = get_artifact(CLI_ARTIFACT_NAME, BASE_URL, token, version)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\jerom\sign-releases\sign_windows_release.py", line 116, in get_artifact
    raise RuntimeError(f"Artifact {artifact_name} not found for version {version}")
RuntimeError: Artifact Windows-x86_64-pc-windows-msvc-cli-pre-build not found for version v3.3.0
@Landeers Landeers added B-Triage Blocker: The issue is awaiting triage C-Bug Issue related to a bug labels Feb 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
B-Triage Blocker: The issue is awaiting triage C-Bug Issue related to a bug
Projects
None yet
Development

No branches or pull requests

1 participant