Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

scoop status says scoop is up to date when offline #3188

Closed
MCOfficer opened this issue Mar 5, 2019 · 0 comments · Fixed by #5031
Closed

scoop status says scoop is up to date when offline #3188

MCOfficer opened this issue Mar 5, 2019 · 0 comments · Fixed by #5031

Comments

@MCOfficer
Copy link
Contributor

MCOfficer commented Mar 5, 2019

To reproduce

  1. Disconnect
  2. Run scoop status
λ» scoop status
fatal: unable to access 'https://github.com/lukesampson/scoop/': Could not resolve host: github.com
Scoop is up to date.
Updates are available for: [...]
Everything is ok!
  1. Reconnect
  2. scoop status again
λ» scoop status
WARN  Scoop is out of date. Run 'scoop update' to get the latest changes.
Updates are available for: [...]

While the error implies that something went wrong while looking for an update (and any savvy user will correctly interpret it as "can't update without internet") saying that scoop is up to date is simply wrong - it's up to date as far as the local scoop knows.

scoop should only say that it's up to date when the update didn't encounter errors, or the error should be more verbose to invalidate the line below it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant