-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(shim): Remove character replacement in .cmd -> .ps1 shims #4914
Conversation
@rashil2000 Could you please look at this? Any suggestions? |
Why do you put two things in one PR? The |
@niheaven Fine. I'll separate them so that you can do the EDITED: Done. And I think the following change can be included in another PR that you will make: @@ -903,7 +903,7 @@ function applist($apps, $global) {
}
function parse_app([string] $app) {
- if($app -match '(?:(?<bucket>[a-zA-Z0-9-]+)\/)?(?<app>.*\.json$|[a-zA-Z0-9-_.]+)(?:@(?<version>.*))?') {
+ if($app -match '^(?:(?<bucket>[a-zA-Z0-9-]+)\/)?(?<app>.*\.json$|[a-zA-Z0-9-_.]+)(?:@(?<version>.*))?$') {
return $matches['app'], $matches['bucket'], $matches['version']
}
return $app, $null, $null Ref: #4910 (comment). |
scoop home
and .cmd -> .ps1 shims
In the CHANGELOG, you should mention this PR (4914), not the issue (4910).
|
@niheaven Got it, thanks. |
Description
See #4910.
Motivation and Context
Partly fix #4910.
Checklist:
develop
branch.