Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(config): Load config file before initialization #4932

Merged
merged 3 commits into from
May 17, 2022

Conversation

sprgchma
Copy link
Contributor

@sprgchma sprgchma commented May 17, 2022

Description

The $scoopConfig is used to initialize several global variables like $scoopdir, but
it was loaded after the initialization. The patch puts the loading before the initialization.

Motivation and Context

Fix #4918

How Has This Been Tested?

Use it in my scoop installation

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly (no new documentation is required)
  • I have updated the tests accordingly. (no new test suite is required)
  • I have added an entry in the CHANGELOG.

The $scoopConfig is used to initialize several global variables like $scoopdir, but
it was loaded after the initialization. The patch puts the loading before the initialization.
@niheaven
Copy link
Member

Please finish the checklist for PR

@niheaven niheaven requested a review from chawyehsu May 17, 2022 09:09
Copy link
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niheaven niheaven changed the title fix: using non-loaded config during initialization fix(config): Load config file before initialization May 17, 2022
@niheaven niheaven merged commit f49f976 into ScoopInstaller:develop May 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants