Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(buckets): Make sure list_buckets return array #4979

Merged
merged 3 commits into from
Jun 10, 2022
Merged

fix(buckets): Make sure list_buckets return array #4979

merged 3 commits into from
Jun 10, 2022

Conversation

danx12
Copy link
Contributor

@danx12 danx12 commented Jun 10, 2022 •
edited
Loading

Description

Forcing $buckets to return as an array.

Motivation and Context

Fix #4978

How Has This Been Tested?

scoop bucket list displays installed buckets again.

Checklist:

  • [ x] I have read the Contributing Guide.
  • [ x] I have ensured that I am targeting the develop branch.
  • [ x] I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@danx12 danx12 marked this pull request as ready for review June 10, 2022 09:16
chawyehsu
chawyehsu previously approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@chawyehsu chawyehsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@chawyehsu
Copy link
Member

Please update CHANGELOG.

@rashil2000
Copy link
Member

I'm unable to reproduce this bug. Is there a test case?

@chawyehsu
Copy link
Member

chawyehsu commented Jun 10, 2022 •
edited
Loading

I'm unable to reproduce this bug. Is there a test case?

Only reproducible when having only one bucket added.

@chawyehsu chawyehsu changed the title fix(buckets): Return as an array fix(buckets): Make sure list_buckets return array Jun 10, 2022
@chawyehsu chawyehsu merged commit 64364b4 into ScoopInstaller:develop Jun 10, 2022
@danx12 danx12 deleted the fix(buckets)-Fix-4978 branch June 10, 2022 10:06
@chawyehsu chawyehsu mentioned this pull request Jun 10, 2022
Merged
@rashil2000
Copy link
Member

I'm unable to reproduce this bug. Is there a test case?

Only reproducible when having only one bucket added.

image

Still works

@chawyehsu
Copy link
Member

chawyehsu commented Jun 10, 2022 •
edited
Loading

@rashil2000 Ahah, you have to use the WinPS5.1 to reproduce at the same time.

@rashil2000
Copy link
Member

Oh, right, my bad. Can repro now 😅

@niheaven niheaven mentioned this pull request Jun 10, 2022
Merged
@josephnarai josephnarai mentioned this pull request Aug 8, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chawyehsu chawyehsu chawyehsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danx12 @chawyehsu @rashil2000