Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[question] Placing of actions on user and project pages #54

Open
micahlt opened this issue Feb 28, 2022 · 4 comments
Open

[question] Placing of actions on user and project pages #54

micahlt opened this issue Feb 28, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request question Further information is requested ui Something related to the user interface of Itchy

Comments

@micahlt
Copy link
Member

micahlt commented Feb 28, 2022

Context: see #46 (comment)

Lots of Android apps place options like "Open in Browser" and "Share" in the top right of the title bar. At the moment, we're placing "Open in Browser" under a FAB along with the "Comments" button on both the user and project pages. This is in accordance with the Material Design guidelines here. Sharing (only on project pages at the moment) is placed in the chip row under the project embed.

The question is how should these icons be placed - for familiarity or ergonomics? The title bar may feel more familiar to some users.
Ergonomically, it's easier to reach under a FAB. Either of these is technically correct according to the MD guidelines - we just have to figure out which one is better for us.

@micahlt micahlt added enhancement New feature or request question Further information is requested labels Feb 28, 2022
@moeenio
Copy link
Member

moeenio commented Mar 6, 2022

Did not read much of the guidelines but:

Use FABs for primary, positive actions.

I believe showing comments does not really count as an action, and opening in browser is not a primary one.

@micahlt
Copy link
Member Author

micahlt commented Mar 6, 2022

Hmm... in my usage of Itchy, I tend to use the "Open in Browser" button a lot - any time I desire to add a comment. What does your usage generally look like?

@moeenio
Copy link
Member

moeenio commented Mar 13, 2022

Here is how my usage looks like :

@moeenio
Copy link
Member

moeenio commented Mar 13, 2022

Jokes aside, as much as you may be using it now, it will not have to be a primary action when more features are implemented.

@micahlt micahlt added the ui Something related to the user interface of Itchy label Apr 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request question Further information is requested ui Something related to the user interface of Itchy
Projects
None yet
Development

No branches or pull requests

2 participants