Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Playing cards will clip the table during translation to markers. #34

Open
Scrivener07 opened this issue Jun 28, 2017 · 10 comments
Open
Labels
blackjack These topics are related to the Blackjack minigame. enhancement

Comments

@Scrivener07
Copy link
Owner

Scrivener07 commented Jun 28, 2017

screenshot66
screenshot67
screenshot68

@Scrivener07 Scrivener07 added blackjack These topics are related to the Blackjack minigame. bug labels Jun 28, 2017
@TheWhiteCollarPlayers
Copy link
Collaborator

A minor issue, but important nonetheless, a potential fix might be raising the starting point of the cards' translation

@Scrivener07
Copy link
Owner Author

I was going to try the spline translate and see what kind of curve I can get,

http://www.creationkit.com/fallout4/index.php?title=SplineTranslateToRef_-_ObjectReference

@Scrivener07 Scrivener07 self-assigned this Jul 2, 2017
@TheWhiteCollarPlayers
Copy link
Collaborator

from our voice discussion: using SplineTranslateToRef with a arching spline for the card to be raised up so that it doesn't clip through the table

@Scrivener07
Copy link
Owner Author

I will try to get this out of the way next time I sit down.

@TheWhiteCollarPlayers
Copy link
Collaborator

Is this fixed? It seems like it to me

@Scrivener07
Copy link
Owner Author

Its not fixed yet. The cards will still clip into other objects.

@TheWhiteCollarPlayers
Copy link
Collaborator

TheWhiteCollarPlayers commented Mar 10, 2018

I believe you made some changes to this with one of your pre release commits. I am happy with how the cards look, consider closing this

@Scrivener07
Copy link
Owner Author

Fixed with pull request #120, closing this.

@Scrivener07
Copy link
Owner Author

Im reopening this because I apparently I didn't fix the clipping that occurs when all cards are collected. This will be addressed some time after v1.2.0. Im also downgrading this from a bug to an enhancement as its a minor cosmetic thing.

@Scrivener07 Scrivener07 reopened this Oct 18, 2018
@Scrivener07 Scrivener07 removed their assignment Oct 18, 2018
@Scrivener07
Copy link
Owner Author

Figuring out how to translate with a spline is still something I have to figure out.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
blackjack These topics are related to the Blackjack minigame. enhancement
Projects
None yet
Development

No branches or pull requests

2 participants