Skip to content

Commit bf0c427

Browse files
committed
[rb] whatever changed in latest chrome to break fedcm tests is not an issue when restart browser between tests
1 parent b162460 commit bf0c427

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

rb/spec/integration/selenium/webdriver/fedcm_spec.rb

+6-6
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,11 @@
2222
module Selenium
2323
module WebDriver
2424
module FedCM
25-
describe FedCM, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: %i[chrome edge]}] do
25+
describe FedCM, exclusive: [{ bidi: false, reason: 'Not yet implemented with BiDi' }, { browser: %i[chrome edge] }] do
2626
let(:dialog) { driver.fedcm_dialog }
2727

28-
before do
29-
driver.get url_for('fedcm/fedcm.html')
30-
end
28+
before { driver.get url_for('fedcm/fedcm.html') }
29+
after { reset_driver! }
3130

3231
context 'without dialog present' do
3332
it 'throws an error' do
@@ -50,7 +49,7 @@ module FedCM
5049
expect(dialog.title).to eq('# to localhost with localhost')
5150
end
5251

53-
it 'returns the subtitle', skip: 'Investigate flakiness only on pipeline' do
52+
it 'returns the subtitle' do
5453
expect(dialog.subtitle).to be_nil
5554
end
5655

@@ -67,7 +66,8 @@ module FedCM
6766
expect(dialog.select_account(1)).to be_nil
6867
end
6968

70-
it 'clicks the dialog', skip: 'Investigate IDP config issue' do
69+
it 'clicks the dialog', except: { browser: %i[chrome edge],
70+
reason: "error: 'Use another account' not supported for this IDP" } do
7171
expect(dialog.click).to be_nil
7272
end
7373

0 commit comments

Comments
 (0)