From bffda0b46ca05e7882dfc3a6dab6c305c39f852c Mon Sep 17 00:00:00 2001 From: blackawa <3104kurokawa@gmail.com> Date: Tue, 19 Apr 2016 00:04:38 +0900 Subject: [PATCH 1/6] fix placeholder typo in vendor prefix for IE --- src/definitions/collections/form.less | 8 ++++---- src/definitions/elements/input.less | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/definitions/collections/form.less b/src/definitions/collections/form.less index 77f4833c1c..35006b4c42 100755 --- a/src/definitions/collections/form.less +++ b/src/definitions/collections/form.less @@ -322,7 +322,7 @@ .ui.form ::-webkit-input-placeholder { color: @inputPlaceholderColor; } -.ui.form ::-ms-input-placeholder { +.ui.form :-ms-input-placeholder { color: @inputPlaceholderColor; } .ui.form ::-moz-placeholder { @@ -332,7 +332,7 @@ .ui.form :focus::-webkit-input-placeholder { color: @inputPlaceholderFocusColor; } -.ui.form :focus::-ms-input-placeholder { +.ui.form :focus:-ms-input-placeholder { color: @inputPlaceholderFocusColor; } .ui.form :focus::-moz-placeholder { @@ -343,7 +343,7 @@ .ui.form .error ::-webkit-input-placeholder { color: @inputErrorPlaceholderColor; } -.ui.form .error ::-ms-input-placeholder { +.ui.form .error :-ms-input-placeholder { color: @inputErrorPlaceholderColor; } .ui.form .error ::-moz-placeholder { @@ -353,7 +353,7 @@ .ui.form .error :focus::-webkit-input-placeholder { color: @inputErrorPlaceholderFocusColor; } -.ui.form .error :focus::-ms-input-placeholder { +.ui.form .error :focus:-ms-input-placeholder { color: @inputErrorPlaceholderFocusColor; } .ui.form .error :focus::-moz-placeholder { diff --git a/src/definitions/elements/input.less b/src/definitions/elements/input.less index 68a9cb6d9c..af2521e10a 100755 --- a/src/definitions/elements/input.less +++ b/src/definitions/elements/input.less @@ -69,7 +69,7 @@ .ui.input input::-moz-placeholder { color: @placeholderColor; } -.ui.input input::-ms-input-placeholder { +.ui.input input:-ms-input-placeholder { color: @placeholderColor; } @@ -162,8 +162,8 @@ .ui.input input:focus::-moz-placeholder { color: @placeholderFocusColor; } -.ui.input.focus input::-ms-input-placeholder, -.ui.input input:focus::-ms-input-placeholder { +.ui.input.focus input:-ms-input-placeholder, +.ui.input input:focus:-ms-input-placeholder { color: @placeholderFocusColor; } @@ -187,7 +187,7 @@ .ui.input.error input::-moz-placeholder { color: @placeholderErrorColor; } -.ui.input.error input::-ms-input-placeholder { +.ui.input.error input:-ms-input-placeholder { color: @placeholderErrorColor; } @@ -198,7 +198,7 @@ .ui.input.error input:focus::-moz-placeholder { color: @placeholderErrorFocusColor; } -.ui.input.error input:focus::-ms-input-placeholder { +.ui.input.error input:focus:-ms-input-placeholder { color: @placeholderErrorFocusColor; } @@ -245,7 +245,7 @@ .ui.transparent.inverted.input input::-moz-placeholder { color: @transparentInvertedPlaceholderColor; } -.ui.transparent.inverted.input input::-ms-input-placeholder { +.ui.transparent.inverted.input input:-ms-input-placeholder { color: @transparentInvertedPlaceholderColor; } From 764321a3d63ad64e777c83400f87c6c087dffb4b Mon Sep 17 00:00:00 2001 From: blackawa <3104kurokawa@gmail.com> Date: Tue, 19 Apr 2016 00:07:19 +0900 Subject: [PATCH 2/6] add !important to enable placeholder styling in IE --- src/definitions/collections/form.less | 4 ++-- src/definitions/elements/input.less | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/definitions/collections/form.less b/src/definitions/collections/form.less index 35006b4c42..3bbe828613 100755 --- a/src/definitions/collections/form.less +++ b/src/definitions/collections/form.less @@ -344,7 +344,7 @@ color: @inputErrorPlaceholderColor; } .ui.form .error :-ms-input-placeholder { - color: @inputErrorPlaceholderColor; + color: @inputErrorPlaceholderColor !important; } .ui.form .error ::-moz-placeholder { color: @inputErrorPlaceholderColor; @@ -354,7 +354,7 @@ color: @inputErrorPlaceholderFocusColor; } .ui.form .error :focus:-ms-input-placeholder { - color: @inputErrorPlaceholderFocusColor; + color: @inputErrorPlaceholderFocusColor !important; } .ui.form .error :focus::-moz-placeholder { color: @inputErrorPlaceholderFocusColor; diff --git a/src/definitions/elements/input.less b/src/definitions/elements/input.less index af2521e10a..dd46531310 100755 --- a/src/definitions/elements/input.less +++ b/src/definitions/elements/input.less @@ -188,7 +188,7 @@ color: @placeholderErrorColor; } .ui.input.error input:-ms-input-placeholder { - color: @placeholderErrorColor; + color: @placeholderErrorColor !important; } /* Focused Error Placeholder */ @@ -199,7 +199,7 @@ color: @placeholderErrorFocusColor; } .ui.input.error input:focus:-ms-input-placeholder { - color: @placeholderErrorFocusColor; + color: @placeholderErrorFocusColor !important; } /******************************* From 83d0585102044477d5124c8922a06650f0251172 Mon Sep 17 00:00:00 2001 From: Jack Lukic Date: Mon, 18 Apr 2016 13:00:38 -0700 Subject: [PATCH 3/6] Add allowReselection setting for dropdown --- RELEASE-NOTES.md | 1 + src/definitions/modules/dropdown.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md index db31498458..b792a70e2c 100644 --- a/RELEASE-NOTES.md +++ b/RELEASE-NOTES.md @@ -6,6 +6,7 @@ - **Webpack** - Modified all relative paths in project to prefix with `./` to make them webpack friendly (wont be misinterpreted as module) - **Popup** - Added new settings `autoRemove`, which is enabled by default. This will add special event listeners to auto hide a popup if the triggering element is removed from the DOM. This is useful in controlled DOM environments like Meteor/Ember/React to ensure a popup auto-hides itself when a page navigation or other DOM change occurs that may not trigger `mouseout`. - **Dropdown** - Added new setting for search selection `hideAdditions` this will remove showing user additions inside the menu, making for a more intuitive adding process. Dropdowns now have a new state `empty` which will format an active dropdown with empty results. #3791 +- **Dropdown** - Adds new `allowReselection` option to trigger `onChange` events even when reselecting same value ***NEEEDS DOCUMENTATION*** - **All UI** - All UI now include _all_ sizing variations, `mini`, `tiny`, `small`, `large`, `big`, `huge`, `massive`. Headers remain with only 5 sizes `small-huge` to match `H1-H5` - **Icons** - Icons now use the latest Font Awesome `4.5.0` Icons. 50+ new icons+ are included. Thanks @BreadMaker for the PR and @davegandy for the font! - **Progress** - Progress now uses a polling interval for updates. Rapidly updating the progress bar over a period quicker than the animation duration (for example with xhr `onprogress` events say every 50ms) will now appear smooth as butter. diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index be9ec39e1c..a38f741247 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -2257,7 +2257,7 @@ $.fn.dropdown = function(parameters) { newValue ; if(hasInput) { - if(stringValue == currentValue) { + if(settings.allowReselection && stringValue == currentValue) { module.verbose('Skipping value update already same value', value, currentValue); if(!module.is.initialLoad()) { return; @@ -3399,6 +3399,7 @@ $.fn.dropdown.settings = { delimiter : ',', // when multiselect uses normal the values will be delimited with this character showOnFocus : true, // show menu on focus + allowReselection : false, // whether current value should trigger callbacks when reselected allowTab : true, // add tabindex to element allowCategorySelection : false, // allow elements with sub-menus to be selected From 57e4f72b9e115b9f2447bb6fa24a8a7c7b25f38f Mon Sep 17 00:00:00 2001 From: Guy Marriott Date: Sat, 23 Apr 2016 00:31:39 +1200 Subject: [PATCH 4/6] Updating regex for email validation --- src/definitions/behaviors/form.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js index 14ef0bd590..b6e76b9403 100644 --- a/src/definitions/behaviors/form.js +++ b/src/definitions/behaviors/form.js @@ -1066,7 +1066,7 @@ $.fn.form.settings = { regExp: { bracket : /\[(.*)\]/i, decimal : /^\d*(\.)\d+/, - email : /.+@.+\..+/i, + email : /^[a-z0-9!#$%&'*+\/=?^_`{|}~.-]+@[a-z0-9]([a-z0-9-]*[a-z0-9])?(\.[a-z0-9]([a-z0-9-]*[a-z0-9])?)*$/i, escape : /[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, flags : /^\/(.*)\/(.*)?/, integer : /^\-?\d+$/, @@ -1174,9 +1174,6 @@ $.fn.form.settings = { // is most likely an email email: function(value){ - var - emailRegExp = new RegExp($.fn.form.settings.regExp.email, 'i') - ; return emailRegExp.test(value); }, From 7762e4e53e915428bb4133696f34a0193ec2721e Mon Sep 17 00:00:00 2001 From: Guy Marriott Date: Sat, 23 Apr 2016 00:37:12 +1200 Subject: [PATCH 5/6] Updating regex for email validation --- src/definitions/behaviors/form.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js index b6e76b9403..7cc653ef13 100644 --- a/src/definitions/behaviors/form.js +++ b/src/definitions/behaviors/form.js @@ -1174,7 +1174,7 @@ $.fn.form.settings = { // is most likely an email email: function(value){ - return emailRegExp.test(value); + return $.fn.form.settings.regExp.email.test(value); }, // value is most likely url From 72dfb7fba24e5de59de66753a298ead116e6b72b Mon Sep 17 00:00:00 2001 From: "johann.rekowski" Date: Tue, 26 Apr 2016 11:01:08 +0200 Subject: [PATCH 6/6] let is not supported on Safari supported browsers reference: http://caniuse.com/#search=let --- src/definitions/modules/dropdown.js | 2 +- src/definitions/modules/popup.js | 2 +- src/definitions/modules/progress.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js index a38f741247..ab47f78118 100644 --- a/src/definitions/modules/dropdown.js +++ b/src/definitions/modules/dropdown.js @@ -3154,7 +3154,7 @@ $.fn.dropdown = function(parameters) { escape: { value: function(value) { - let + var multipleValues = $.isArray(value), stringValue = (typeof value === 'string'), isUnparsable = (!stringValue && !multipleValues), diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js index 1505825832..212875da9b 100644 --- a/src/definitions/modules/popup.js +++ b/src/definitions/modules/popup.js @@ -189,7 +189,7 @@ $.fn.popup = function(parameters) { } }, hideGracefully: function(event) { - let + var $target = $(event.target), isInDOM = $.contains(document.documentElement, event.target), inPopup = ($target.closest(selector.popup).length > 0) diff --git a/src/definitions/modules/progress.js b/src/definitions/modules/progress.js index ccee96bfc3..132199d7c7 100644 --- a/src/definitions/modules/progress.js +++ b/src/definitions/modules/progress.js @@ -601,7 +601,7 @@ $.fn.progress = function(parameters) { update: { toNextValue: function() { - let + var nextValue = module.nextValue ; if(nextValue) {