You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
usually occurs in key_is_file_on_s3(), and it would be nice for it to also display what key it was trying to access, ie f"Key {s3_key} does not exist on S3"
The text was updated successfully, but these errors were encountered:
I almost have a long-term vision for this, so I'll detail it here:
Most everything should raise an Exception by default (which should be more verbose, like you mentioned).
Most exceptions fall into some set categories (which we can detail later), but as a result it should be configurable to ignore certain types with specified behvior (i.e. return None), and trigger an associated logging event at the appropriate level.
Then log levels could be muted/streamed directly.
The one caveat is that logging is intended for all users of a program, while warnings is specifically designed for messages to programmers, so good practice would require keeping audience in mind during this logging.
I'll address this specific one on it's own and open a new issue at that point with a slightly more revised plan of this sort.
usually occurs in
key_is_file_on_s3()
, and it would be nice for it to also display what key it was trying to access, ief"Key {s3_key} does not exist on S3"
The text was updated successfully, but these errors were encountered: