Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More verbose "ValueError: Key does not exist on S3" #22

Closed
TrevorBurgoyne opened this issue Jun 2, 2023 · 1 comment · Fixed by #24
Closed

More verbose "ValueError: Key does not exist on S3" #22

TrevorBurgoyne opened this issue Jun 2, 2023 · 1 comment · Fixed by #24
Assignees
Labels
enhancement New feature or request

Comments

@TrevorBurgoyne
Copy link
Member

usually occurs in key_is_file_on_s3(), and it would be nice for it to also display what key it was trying to access, ie f"Key {s3_key} does not exist on S3"

@TrevorBurgoyne TrevorBurgoyne added the enhancement New feature or request label Jun 2, 2023
@joshua-dean joshua-dean self-assigned this Jun 5, 2023
@joshua-dean
Copy link
Collaborator

I almost have a long-term vision for this, so I'll detail it here:
Most everything should raise an Exception by default (which should be more verbose, like you mentioned).
Most exceptions fall into some set categories (which we can detail later), but as a result it should be configurable to ignore certain types with specified behvior (i.e. return None), and trigger an associated logging event at the appropriate level.
Then log levels could be muted/streamed directly.
The one caveat is that logging is intended for all users of a program, while warnings is specifically designed for messages to programmers, so good practice would require keeping audience in mind during this logging.

I'll address this specific one on it's own and open a new issue at that point with a slightly more revised plan of this sort.

This was referenced Oct 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants