Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Browser: Popup menu in stylesheet inspector doesn't work #25407

Open
nico opened this issue Nov 16, 2024 · 1 comment
Open

Browser: Popup menu in stylesheet inspector doesn't work #25407

nico opened this issue Nov 16, 2024 · 1 comment

Comments

@nico
Copy link
Contributor

nico commented Nov 16, 2024

We'll probably need something like 549f5fe for Userland/Applications/Browser too. Tab.{h,cpp} currently has RefPtr<GUI::Menu> m_select_dropdown and that has to move to the view impl.

However, as far as I can tell, that's currently LibWebView/OutOfProcessWebView, and that probably shouldn't have access to LibGUI (?).
@nico nico changed the title Popup menu in stylesheet inspector doesn't work Browser: Popup menu in stylesheet inspector doesn't work Nov 17, 2024
@nico
Copy link
Contributor Author

nico commented Dec 3, 2024

OutOfProcessWebView already depends on LibGUI, so short term putting it there looks like the clear path forward.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nico