Clippy and rustfmt

[mo8it]

I was surprised that this crate isn't using Clippy (many pending lints) and isn't formatted using rustfmt. This makes reading the code and contributing harder, at least for me. Are you open for a PR to use both?

[SergioBenitez]

I was surprised that this crate isn't using Clippy (many pending lints)

We do use clippy, we just don't fix every lint because not all of them are strict improvements. Instead of peppering the codebase with allow(clippy) annotations, we either declare them in the [lints.clippy] Cargo.toml file or leave them be.

and isn't formatted using rustfmt. This makes reading the code and contributing harder, at least for me.

As of the last time I checked, rustfmt is still unable to format a bunch of reasonable code (like things in macro invocations) in a reasonable manner. Nevertheless, we do have code style guidelines that we rather strictly enforce. Which code are you finding hard to read?

Are you open for a PR to use both?

We have tried rustfmt many times and each time has ended poorly. As a result we committed a rustfmt file that simply disables rustfmt. If the state of rustfmt has changed significantly then I'm happy to try again, but we would want the most conservative settings that result in the smallest diff.

As for clippy: as I said we do use clippy, but if you have ways to improve our use of want to submit fixes that clippy identified, they are absolutely welcome!

[SergioBenitez]

Closing as there's nothing directly actionable. Happy to field PRs as indicated above.