Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider to use the lowest possible Rust version #35

Open
qarmin opened this issue Feb 21, 2022 · 3 comments
Open

Consider to use the lowest possible Rust version #35

qarmin opened this issue Feb 21, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@qarmin
Copy link

qarmin commented Feb 21, 2022

Most of libraries which I used, needed to use the lowest possible Rust version(usually support latest 10 versions, so if newest is 1.58, latest supported is 1.48)

Lofty currently require Rust 1.57.0, which is only 1 release behind official Rust release.

To pack software for Ubuntu 20.04 I need to use specific Rust version, 1 week ago it was Rust 1.53.0, but now it is Rust 1.57.0(https://packages.ubuntu.com/search?keywords=rust&searchon=names&suite=impish&section=all)

For future I think that it would be great if lofty would pin to some older version of Rust to help to package apps which use this libraries on older/specific OS.

@qarmin qarmin added the enhancement New feature or request label Feb 21, 2022
@Serial-ATA
Copy link
Owner

Hm, I hadn't thought about setting a MSRV. While I don't want to speak too early, I don't think it'll need to go above 1.57 anytime soon, since I just needed it for try_reserve. I can't guarantee that till 1.0, though.

And I wasn't aware that some distros were that far behind, thanks for bringing that to my attention. I'll take that into consideration if I do ever try to bump the version.

@qarmin
Copy link
Author

qarmin commented Dec 29, 2022

Looks that lofty needs now Rust 1.65.0 due rust-lang/rust#96709

error[E0658]: generic associated types are unstable
   --> /home/runner/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/lofty-0.10.0/src/traits.rs:137:2
    |
137 | /     type RefKey<'a>
138 | |     where
139 | |         Self: 'a;
    | |_________________^
    |
    = note: see issue #44265 <https://github.com/rust-lang/rust/issues/44265> for more information

@Serial-ATA
Copy link
Owner

It's unfortunate how far behind Ubuntu is, 1.65.0 is almost 2 months old at this point. Do they have a rule that they only push out the 4th release of rustc? Having gone 1.57.0 -> 1.61.0, I'd assume 1.65.0 is on its way sometime soon?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants