Skip cache logic when mode is no-store (#964)

* Skip cache logic when cache mode is no-store * Changesets
Shopify · Jun 1, 2023 · 8ccf6db · 8ccf6db
1 parent dbc7452
commit 8ccf6db
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/modern-rats-dance.md b/.changeset/modern-rats-dance.md
@@ -0,0 +1,5 @@
+---
+'@shopify/hydrogen': patch
+---
+
+Skip reading and writing cache in sub-requests when the strategy is CacheNone.
diff --git a/packages/hydrogen/src/cache/fetch.ts b/packages/hydrogen/src/cache/fetch.ts
@@ -1,5 +1,5 @@
 import {hashKey} from '../utils/hash.js';
-import {CacheShort, CachingStrategy} from './strategies';
+import {CacheShort, CachingStrategy, NO_STORE} from './strategies';
 import {getItemFromCache, setItemInCache, isStale} from './sub-request';
 
 /**
@@ -59,7 +59,9 @@ export async function runWithCache<T = unknown>(
     waitUntil,
   }: WithCacheOptions<T>,
 ): Promise<T> {
-  if (!cacheInstance || !strategy) return actionFn();
+  if (!cacheInstance || !strategy || strategy.mode === NO_STORE) {
+    return actionFn();
+  }
 
   const key = hashKey([
     // '__HYDROGEN_CACHE_ID__', // TODO purgeQueryCacheOnBuild