Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add @total-typescript/ts-reset to skeleton and demo-store #1042

Merged
merged 4 commits into from
Jul 6, 2023
Merged

add @total-typescript/ts-reset to skeleton and demo-store #1042

merged 4 commits into from
Jul 6, 2023

Conversation

juanpprieto
Copy link
Contributor

WHAT is this pull request doing?

Adds @total-typescript/ts-reset to demo-store and skeleton templates

HOW to test your changes?

add this code to any route / component and check the type

const test = [1, undefined, null, 3, fal, 'test'].filter(Boolean)
  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes

@juanpprieto
add @total-typescript/ts-reset to skeleton and demo-store
1d401c6 
add changesetg

fix typecheck and removed unused code
@juanpprieto juanpprieto force-pushed the juanpprieto/add-ts-reset-to-skeleton-and-demo-store branch from 63ff836 to 1d401c6 Compare June 26, 2023 10:40
@juanpprieto juanpprieto requested a review from a team June 26, 2023 11:20
@github-actions github-actions bot had a problem deploying to preview July 6, 2023 20:59 Failure
wizardlyhel
wizardlyhel approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up, sync'ed and ready to go

@github-actions github-actions bot had a problem deploying to preview July 6, 2023 21:14 Failure
@github-actions github-actions bot had a problem deploying to preview July 6, 2023 21:35 Failure
@wizardlyhel wizardlyhel merged commit 0f7042b into 2023-04 Jul 6, 2023
@wizardlyhel wizardlyhel deleted the juanpprieto/add-ts-reset-to-skeleton-and-demo-store branch July 6, 2023 21:50
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 6, 2023
Closed
juanpprieto added a commit that referenced this pull request Jul 10, 2023
@juanpprieto @wizardlyhel
add @total-typescript/ts-reset to skeleton and demo-store (#1042)
57bd984 
* add @total-typescript/ts-reset to skeleton and demo-store

Co-authored-by: Helen Lin <helen.lin@shopify.com>
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 25, 2023
Merged
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
@juanpprieto @wizardlyhel @FrcPpe
add @total-typescript/ts-reset to skeleton and demo-store (Shopify#1042)
d1ca99e 
* add @total-typescript/ts-reset to skeleton and demo-store

Co-authored-by: Helen Lin <helen.lin@shopify.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wizardlyhel wizardlyhel wizardlyhel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpprieto @wizardlyhel