Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cart): parameter of CART_ATTRIBUTES_UPDATE_MUTATION #1117

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix(cart): parameter of CART_ATTRIBUTES_UPDATE_MUTATION #1117

merged 3 commits into from
Jul 20, 2023

Conversation

remcolakens
Copy link
Contributor

@remcolakens remcolakens commented Jul 19, 2023 •
edited
Loading

WHY are these changes introduced?

Looks like --codegen-unstable could not generate new types due to a misconfigured type.

WHAT is this pull request doing?

Fixed the $attributes type with the correct one

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@juanpprieto juanpprieto requested a review from wizardlyhel July 19, 2023 17:43
wizardlyhel
wizardlyhel approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch

@wizardlyhel
Copy link
Contributor

Would you run npm run changeset to create a changeset entry? Select @shopify/hydrogen and select patch version change

@remcolakens
Copy link
Contributor Author

Sure thing! Just added the new changeset entry for this fix

@wizardlyhel wizardlyhel merged commit 3140987 into Shopify:2023-04 Jul 20, 2023
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 20, 2023
Closed
@remcolakens remcolakens deleted the fix/cart-attribute-type branch July 21, 2023 07:17
@remcolakens remcolakens restored the fix/cart-attribute-type branch July 21, 2023 07:21
@remcolakens remcolakens deleted the fix/cart-attribute-type branch July 21, 2023 07:22
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 25, 2023
Merged
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
@remcolakens @FrcPpe
fix(cart): parameter of CART_ATTRIBUTES_UPDATE_MUTATION (Shopify#1117)
4c30f5a
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wizardlyhel wizardlyhel wizardlyhel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcolakens @wizardlyhel