Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: remove dynamic import for SourceMapConsumer #2738

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ruggishop
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@ruggishop
Copy link
Contributor Author

/snapit

Copy link
Contributor

shopify bot commented Jan 30, 2025

Oxygen deployed a preview of your fix/fr-import-source-map-consumer branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment February 4, 2025 5:56 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 4, 2025 5:56 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment February 4, 2025 5:56 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment February 4, 2025 5:56 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment February 4, 2025 5:56 PM

Learn more about Hydrogen's GitHub integration.

@ruggishop ruggishop force-pushed the fix/fr-import-source-map-consumer branch from 93a9bb7 to 1681e50 Compare January 30, 2025 17:38
@ruggishop
Copy link
Contributor Author

/snapit

@wizardlyhel
Copy link
Contributor

/snapit

Copy link
Contributor

github-actions bot commented Feb 4, 2025

🫰✨ Thanks @wizardlyhel! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20250204175950",
"@shopify/hydrogen": "0.0.0-snapshot-20250204175950"

Create a new project with all the released packages running npm create @shopify/hydrogen@<snapshot_version>
To try a new CLI plugin version, add @shopify/cli-hydrogen as a dependency to your project using the snapshot version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants