Adopt v2 route conventions in demo-store #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
frandiox
changed the title
frehner
reviewed
Apr 6, 2023
.changeset/early-jobs-fail.md
Outdated
|
|
||
| Remix v2 route conventions are just file renames. We just need to ensure when changing file name and file location, the import paths of other files are also updated. | ||
|
|
||
| Here is an example list of file renames for the demo store: |
There was a problem hiding this comment.
This is a confusing changeset for a developer to read and understand. Can you clarify what we expect developers to do in this release? Is this a breaking change for devs using Hydrogen?
frehner
approved these changes
Apr 11, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-do:
Figure out how to do skeleton template generation between v1 and v2 route conventionsSupport Remix v2 in route generator #756Checklist