Fix buyerIp warning #836
Merged
Fix buyerIp warning #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frandiox
commented
May 1, 2023
Comment on lines
165
to
166
| defaultHeaders[STOREFRONT_REQUEST_GROUP_ID_HEADER] = | ||
| storefrontHeaders?.requestGroupId || requestGroupId || generateUUID(); |
There was a problem hiding this comment.
@frehner Not related to this PR but should we move STOREFRONT_REQUEST_GROUP_ID_HEADER to hydrogen-react?
There was a problem hiding this comment.
Everything that is common to using the SFAPI (and not specific to Hydrogen) should be in hydrogen-react, yeah.
|
Going to wait until a new version of MiniOxygen is released with |
cartogram
approved these changes
May 2, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue mentioned in this discussion #814 has two parts:
buyerIpdirectly to the SFAPI request headers (so it worked) but we were not doing it via hydrogen-react, which was showing a warning. -- 🟩 Fixed in this PR