Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to Remix 1.17.1 #852

Merged
merged 15 commits into from
Jun 15, 2023
Merged

Upgrade to Remix 1.17.1 #852

merged 15 commits into from
Jun 15, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented May 8, 2023

WHY are these changes introduced?

WIP - Blocked by remix-run/remix#6348

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@github-actions github-actions bot had a problem deploying to preview May 8, 2023 09:25 Failure
@blittle
Copy link
Contributor

blittle commented Jun 1, 2023

I saw some of our pinned dependencies, and started to update them, then noticed the work is already done here :)

I wonder if this will resolve some of these weird type issues we are seeing in the demostore: #972

@frandiox
Copy link
Contributor Author

frandiox commented Jun 2, 2023

I'm not sure this will fix it 🤔 -- I've seen a related issue for a few versions already, although not sure if it's the same as the one reported there.
We have a workaround for the issue I've mentioned here (when mixing defer with json / redirect).

@MichaelDeBoey
Copy link

We just published version 1.17.1-pre.0 which includes remix-run/remix#6562 (a possible fix). If you'd like to take it for a test run please try it out and let us know what you think!

@frandiox frandiox changed the title [WIP] Upgrade to Remix 1.16 [WIP] Upgrade to Remix 1.17 Jun 9, 2023
@frandiox frandiox changed the title [WIP] Upgrade to Remix 1.17 Upgrade to Remix 1.17.1 Jun 15, 2023
@frandiox frandiox marked this pull request as ready for review June 15, 2023 16:47
@frandiox frandiox requested a review from blittle June 15, 2023 16:47
@github-actions

This comment has been minimized.

@frandiox frandiox requested a review from a team June 15, 2023 16:48
@blittle blittle merged commit f29e178 into 2023-04 Jun 15, 2023
@blittle blittle deleted the fd-remix-1.16 branch June 15, 2023 17:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants