Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docs for cart abstraction #882

Merged
merged 74 commits into from
Jul 4, 2023
Merged

Docs for cart abstraction #882

merged 74 commits into from
Jul 4, 2023

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented May 12, 2023

WHY are these changes introduced?

Doc links (Shopify employee only)

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@github-actions github-actions bot had a problem deploying to preview May 15, 2023 20:41 Failure
@github-actions github-actions bot had a problem deploying to preview May 17, 2023 15:45 Failure
@github-actions github-actions bot had a problem deploying to preview June 23, 2023 18:49 Failure
@github-actions github-actions bot had a problem deploying to preview June 23, 2023 18:53 Failure
@github-actions github-actions bot had a problem deploying to preview June 23, 2023 19:43 Failure
@github-actions github-actions bot had a problem deploying to preview June 26, 2023 18:05 Failure
@github-actions github-actions bot had a problem deploying to preview June 27, 2023 17:33 Failure
@github-actions github-actions bot had a problem deploying to preview June 27, 2023 17:39 Failure
@github-actions github-actions bot had a problem deploying to preview June 28, 2023 18:22 Failure
@github-actions github-actions bot had a problem deploying to preview June 28, 2023 21:22 Failure
@github-actions github-actions bot had a problem deploying to preview June 28, 2023 21:28 Failure
@github-actions github-actions bot had a problem deploying to preview June 28, 2023 21:29 Failure
@github-actions github-actions bot had a problem deploying to preview June 28, 2023 21:51 Failure
isVisualComponent: false,
related: [],
description:
'Creates a form for managing cart operations. Use `CartActionInput` to accept form inputs of known type.',
Copy link
Contributor

@blittle blittle Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me by these docs that I can also just put a vanilla input inside the cart form. Can I do that with all of the different cart actions input data? Or only a few? Worth a separate example so we show both ways?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nm, because MacOS hides scrollbars, I didn't realize I could scroll down the page and see the other examples. Though I think it would be a good idea to maybe show the same usecase in the different examples where it makes sense. Like can I add an item to the cart just via form inputs?

isVisualComponent: false,
related: [],
description:
'Creates a function that accepts an array of [AttributeInput](/docs/api/storefront/2023-04/input-objects/AttributeInput) and updates attributes to a cart',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for each of these we could add a note that they are to be used within an action. Maybe even if the examples themselves just show them in an action?

Suggested change
'Creates a function that accepts an array of [AttributeInput](/docs/api/storefront/2023-04/input-objects/AttributeInput) and updates attributes to a cart',
'Creates a function that accepts an array of [AttributeInput](/docs/api/storefront/2023-04/input-objects/AttributeInput) and updates attributes to a cart',

@github-actions github-actions bot had a problem deploying to preview June 30, 2023 19:14 Failure
@wizardlyhel wizardlyhel merged commit 6d4cc17 into hl-cart Jul 4, 2023
@wizardlyhel wizardlyhel deleted the hl-cart-docs branch July 4, 2023 21:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants