-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Docs for cart abstraction #882
Conversation
isVisualComponent: false, | ||
related: [], | ||
description: | ||
'Creates a form for managing cart operations. Use `CartActionInput` to accept form inputs of known type.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me by these docs that I can also just put a vanilla input
inside the cart form. Can I do that with all of the different cart actions input data? Or only a few? Worth a separate example so we show both ways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nm, because MacOS hides scrollbars, I didn't realize I could scroll down the page and see the other examples. Though I think it would be a good idea to maybe show the same usecase in the different examples where it makes sense. Like can I add an item to the cart just via form inputs?
isVisualComponent: false, | ||
related: [], | ||
description: | ||
'Creates a function that accepts an array of [AttributeInput](/docs/api/storefront/2023-04/input-objects/AttributeInput) and updates attributes to a cart', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for each of these we could add a note that they are to be used within an action. Maybe even if the examples themselves just show them in an action?
'Creates a function that accepts an array of [AttributeInput](/docs/api/storefront/2023-04/input-objects/AttributeInput) and updates attributes to a cart', | |
'Creates a function that accepts an array of [AttributeInput](/docs/api/storefront/2023-04/input-objects/AttributeInput) and updates attributes to a cart', |
WHY are these changes introduced?
Doc links (Shopify employee only)
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist