Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Rest client. Get request with query fails if the limit is not specified #134

Closed
1 task done
derom opened this issue Mar 13, 2021 · 0 comments · Fixed by #135
Closed
1 task done

Rest client. Get request with query fails if the limit is not specified #134

derom opened this issue Mar 13, 2021 · 0 comments · Fixed by #135

Comments

@derom
Copy link
Contributor

derom commented Mar 13, 2021

Issue summary

With this kind of request

client.get({
  path: 'redirects',
  query: {
	  "path": 'some_path',
  },
});

I get error, because limit is undefined

Expected behavior

Successful request to the api

Actual behavior

I get error UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'toString' of undefined
which comes from this row https://github.com/Shopify/shopify-node-api/blob/7c9201af556c6f82deb936215f5099d08e35f727/src/clients/rest/rest_client.ts#L35


Checklist

  • I have described this issue in a way that is actionable (if possible)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant