Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Add a TLS flag in RedisSessionStorage #416

Closed
3 of 4 tasks
walkingbrad opened this issue Jun 29, 2022 · 0 comments · Fixed by #430
Closed
3 of 4 tasks

Add a TLS flag in RedisSessionStorage #416

walkingbrad opened this issue Jun 29, 2022 · 0 comments · Fixed by #430
Assignees

Comments

@walkingbrad
Copy link

walkingbrad commented Jun 29, 2022

Overview

The implementation of RedisSessionStorage has no way of enabling TLS in the underlying Redis client it creates.

Type

  • New feature
  • Changes to existing features

Motivation

What inspired this feature request? What problems were you facing?

Heroku requires that non-hobby (i.e. production-ready) Redis instances always use TLS, so it's impossible to use RedisSessionStorage with Heroku Redis in production.

It effectively hard-codes this:

client = createClient({
    url: dbUrl,
})

where it should allow another flag to be passed such that we can create the client with TLS like this:

client = createClient({
  url: dbUrl,
  socket: {
    tls: true,
    rejectUnauthorized: false,
  },
})

Area

  • Add any relevant Area: <area> labels to this issue

??

Checklist

  • I have described this feature request in a way that is actionable (if possible)
@darius-gai darius-gai self-assigned this Jul 4, 2022
@darius-gai darius-gai removed their assignment Jul 18, 2022
@darius-gai darius-gai added this to the Q3C1 - Week 4 - July 22 milestone Jul 18, 2022
@paulomarg paulomarg self-assigned this Jul 22, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants