Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Filter "Niet bepaald" at Stadsdelen does not work properly #118

Open
someren opened this issue Mar 5, 2021 · 3 comments · Fixed by Amsterdam/signals-frontend#2073
Open
Assignees
Labels
bug Something isn't working

Comments

@someren
Copy link

someren commented Mar 5, 2021

Describe the bug
You can filter on Stadsdelen or simply choose the option "Niet bepaald". The result shows signals/tickets which do have a Stadsdeel. This filter does not work correctly. I expect a list with signals/tickets which do not have a Stadsdeel.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Filteren
  2. Click on Stadsdeel > Niet bepaald
  3. Click on "Filteren"
  4. See list with tickets/signals which have a Stadsdeel instead of an empty one.

Expected behavior
I expect to create a list with tickets/signals that do not have a Stadsdeel and are somewhat 'lost'.

Screenshots
Filter:

Filter stadsdeel niet bepaald 1

Result (is from acceptatieomgeving, production showed only 1 result):

Filter stadsdeel niet bepaald 2

Desktop (please complete the following information):

  • OS: Microsoft
  • Browser: Chrome
@CBuiVNG
Copy link

CBuiVNG commented Mar 18, 2021

this is a back-end issue. I've made a PR Amsterdam/signals#756 to correct this

@tcoenen
Copy link

tcoenen commented Feb 16, 2022

I saw this still does not work correctly, there are a few issues. One is that the backend does not accept area_type_code=null to filter on, for which I have a PR open: Amsterdam/signals#932

The other issue is that the frontend erroneously filters on area_type_code=district for Signal instances that have no area determined. If "Signalen" was not able to determine in which area a Signal (nuisance complaint) lies it will not set either of the area_code and area_type_code properties for that Signal's location. The aforementioned filtering will not work because area_type_code will have value null (and not district) in the database.

@someren
Copy link
Author

someren commented Mar 14, 2022

Getest op versie 2.4.1, issue speelt nog steeds

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants