Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Manage photos of a report #160

Open
boris-arkenaar opened this issue Jan 4, 2022 · 2 comments · Fixed by Amsterdam/signals-frontend#2156
Open

Manage photos of a report #160

boris-arkenaar opened this issue Jan 4, 2022 · 2 comments · Fixed by Amsterdam/signals-frontend#2156
Assignees
@boris-arkenaar
Labels
Epic: add and send photos Allow an employee to add photos to a report and send them to the reporter

Comments

@boris-arkenaar
Copy link

boris-arkenaar commented Jan 4, 2022 •
edited
Loading

UI design

Photos get their own section on the signal detail page.

Show the photos

  • Show for each photo the date they were added
  • Show for each photo who uploaded the photo (email address of employee, or 'reporter')

Upload a photo

  • Use the same upload components as are being used in the signal form (for the MVP at least)
  • Make sure to update the signal history after the photo has been uploaded

Delete a photo

  • Only allow the employee who uploaded the photo to delete it
  • Also allow a user with the right permission to delete a photo
  • The photos uploaded by the reporter cannot be deleted
  • Show a native browser dialog to ask for confirmation before deleting a photo
@boris-arkenaar boris-arkenaar added the Epic: add and send photos Allow an employee to add photos to a report and send them to the reporter label Jan 4, 2022
@boris-arkenaar boris-arkenaar self-assigned this Mar 17, 2022
@tcoenen
Copy link

tcoenen commented May 13, 2022

Backend will likely be released today - if it is I will install that release on acceptatie. Note also that history entries are added for uploads as well, that ticket was reviewed and merged in Amsterdam.

@tcoenen
Copy link

tcoenen commented May 17, 2022

I have released a new version of the Helm Charts that makes the relevant permissions available through the API (by setting: settings.excludedPermissionsInResponses correctly).

@boris-arkenaar boris-arkenaar mentioned this issue Jun 28, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@boris-arkenaar boris-arkenaar

Labels
Epic: add and send photos Allow an employee to add photos to a report and send them to the reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/160 manage photos of a report Signalen/frontend
2 participants
@tcoenen @boris-arkenaar