Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding lang as a new file #136

Closed
TheLimeGlass opened this issue Jul 18, 2016 · 8 comments
Closed

Adding lang as a new file #136

TheLimeGlass opened this issue Jul 18, 2016 · 8 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@TheLimeGlass
Copy link
Contributor

Can we please get the lang files as a new configurable file in the Skript folder?

https://github.com/bensku/Skript/blob/master/src/main/resources/lang/english.lang

@JavierKasunic
Copy link

It's already configurable, but it's not in the Skript folder.

@ghost
Copy link

ghost commented Jul 19, 2016

@JKGamerxD He knows, he wants it to actually be in the folder lol

@bensku
Copy link
Member

bensku commented Jul 19, 2016

This is clearly intended feature, though I do not know why so. Most likely, by providing invalid English language file, you can cause serious trouble. Other language files will default to english, so they're not so critical...

Currently you can create your own language "customenglish.lang" and copy-paste english lang file. It would be better to have Skript treat jar's English language as different than user-specified language. That would be not so easy to code, and I'm not going to do it very soon.

@bensku bensku added enhancement Feature request, an issue about something that could be improved, or a PR improving something. help wanted labels Jul 19, 2016
@Blueyescat
Copy link
Contributor

You can copy lang folder to plugins/Skript/ folder currently 🤔 not there by default. Still needs restart to reload.

@Snow-Pyon Snow-Pyon added the priority: low Issues that are not harmful to the experience but are related to useful changes or additions. label Jan 31, 2018
@TheLimeGlass
Copy link
Contributor Author

TheLimeGlass commented Mar 14, 2018

@Blueyescat did you delete the original lang file from the jar, otherwise it's just redundant and using the lang file from the jar, meaning that test is flawed.

I realize now that this would need a whole re-write. Keep in mind that this feature was intended to be used for addons, which is why it's not a file in the data folder of Skript, that or it was too much work and Njol didn't see a need. Skript's lang file could be placed in it's own folder like plugins/Skript/languages/lang_en because this was designed for multiple languages to keep in mind if anyone tackles this.

@Blueyescat
Copy link
Contributor

No i didn't and it works fine.

@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label May 15, 2021
@TPGamesNL TPGamesNL mentioned this issue Jul 20, 2021
1 task
@thonkinator
Copy link

thonkinator commented Sep 6, 2021

Sorry for being picky about labeling but this is an intended feature that isn't implemented, as stated by https://github.com/SkriptLang/Skript/blob/master/src/main/resources/lang/readme.txt, not an enhancement.

@TPGamesNL
Copy link
Member

From that file:

You can either put language files into the lang folder in the jar or into the plugins/Skript/lang/ folder, but files in the latter folder take precedence
(If there are two files for the same language both will be loaded but the file in the folder will overwrite values from the file in the jar)
The exception to this rule is the default english file which is only loaded from the jar.

@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

8 participants