Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Week support in timespans #2220

Closed
MrScopes opened this issue Jul 2, 2019 · 5 comments
Closed

Week support in timespans #2220

MrScopes opened this issue Jul 2, 2019 · 5 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@MrScopes
Copy link
Contributor

MrScopes commented Jul 2, 2019

timespans should support week, month, and year, instead of just seconds, minutes, hours, and days.

@Blueyescat
Copy link
Contributor

month is indeterminate

@Whimsyturtle
Copy link
Member

This could be possible if Skript made the assumption that all months are 30 days and all years are 365 days although that may be slightly inconsistent

@Blueyescat
Copy link
Contributor

It is better to left them to the user, but Skript needs some easy to use timespan utilities.

@TPGamesNL
Copy link
Member

Something like (ticks|seconds|minutes|...) of %timespan% would be nice.

@TheBentoBox TheBentoBox added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Jul 8, 2019
@TheBentoBox
Copy link
Member

At the very least it could support weeks. Something in the config to determine the level at which timespans reach would be useful (i.e. allowing it to go up to weeks or years instead of the current days). As has been said, months are not a viable static unit of measurement. Years aren't quite either with leap years.

@Whimsyturtle Whimsyturtle changed the title (week, month, year) support Week support in timespans Oct 17, 2019
@TPGamesNL TPGamesNL added PR available Issues which have a yet-to-be merged PR resolving it completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Nov 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

6 participants