Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ExprAmount invalid parsing #3333

Closed
TPGamesNL opened this issue Aug 24, 2020 · 0 comments
Closed

ExprAmount invalid parsing #3333

TPGamesNL opened this issue Aug 24, 2020 · 0 comments
Assignees
@APickledWalrus
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@TPGamesNL
Copy link
Member

TPGamesNL commented Aug 24, 2020 •
edited
Loading

Steps to Reproduce

set {_x} to amount of {_a::*} and abc parses successfully, gives error when executed

Expected Behavior

Should error on parse

Errors / Screenshots

https://pastebin.com/LWui4Q0U

Server Information

  • Server version/platform: Paper-347 (1.15.2)
  • Skript version: 2.5-beta2

Additional Context

This happens because ExprAmount uses %objects% (not %object%), but it only checks if the given expression is an instance of Literal (which includes UnparsedLiteral), not if the given expression is an ExpressionList that contains Literals / UnparsedLiterals.
@FranKusmiruk FranKusmiruk added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Aug 24, 2020
@APickledWalrus APickledWalrus self-assigned this Oct 4, 2020
@APickledWalrus APickledWalrus mentioned this issue Oct 4, 2020
Merged
@APickledWalrus APickledWalrus added the completed The issue has been fully resolved and the change will be in the next Skript update. label Oct 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@APickledWalrus APickledWalrus

Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@APickledWalrus @TPGamesNL @FranKusmiruk