Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing getHitEntity() in "on projectile hit" event #3746

Closed
AyhamAl-Ali opened this issue Feb 11, 2021 · 1 comment
Closed

Missing getHitEntity() in "on projectile hit" event #3746

AyhamAl-Ali opened this issue Feb 11, 2021 · 1 comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@AyhamAl-Ali
Copy link
Member

Description

on projectile hit event should have event-entity or hit entity to get the hit entity, it is available in spigot but not found/working in Skript.

The issue here is that when using fishing rod on players there is no damage so on damage event won't even fire and on projectile hit doesn't have hit entity so there is no way to check for that.

Steps to Reproduce

No steps.

Expected Behavior

None.

Errors / Screenshots

Server Information

  • Server version/platform: Paper 1.16.5-R0.1-Snapshot "b89788a"
  • Skript version: Skript 2.5.3

Additional Context
@Pikachu920
Copy link
Member

it would probably make sense to add this to the victim expression

@Mr-Darth Mr-Darth mentioned this issue Feb 20, 2021
Merged
@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Feb 20, 2021
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 23, 2021
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AyhamAl-Ali @Pikachu920 @APickledWalrus @TPGamesNL