Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reverse sections order #4446

Closed
1 task done
Olyno opened this issue Nov 26, 2021 · 0 comments
Closed
1 task done

Reverse sections order #4446

Olyno opened this issue Nov 26, 2021 · 0 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Olyno
Copy link
Contributor

Olyno commented Nov 26, 2021

Suggestion

Currently, when trying to get the current section (ParserInstance#getCurrentSection(Class<?> clazz), we're getting the first matched section.

ParserInstance#isCurrentSection would make more sense to return the innermost section instead of the outermost one

From @TPGamesNL

Why?

In this example:

command /test:
    trigger:
        make new email:
            make new email contact:
                set {_x} to email contact

It not gonna work because the returned section is new email, and not new email contact.

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this suggestion.
@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. PR available Issues which have a yet-to-be merged PR resolving it labels Nov 26, 2021
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Dec 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

3 participants