Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Retry register device token will remove topic ID #483

Closed
2 tasks
cychiuae opened this issue Jan 23, 2019 · 0 comments
Closed
2 tasks

[BUG] Retry register device token will remove topic ID #483

cychiuae opened this issue Jan 23, 2019 · 0 comments
Labels

Comments

@cychiuae
Copy link
Contributor

If the deviceID is deleted remotely, by apns feedback. When SDK tries to retry registering device token to server, the topic ID will be removed.

That is because in

return this.registerDevice(token, type);

We don't pass topicID to retry method

  • Skygear SDK Date/Version: 1.6.4
  • JS runtime: react-native
  • Skygear Server Date/Version: 1.6.x
  • Is this a regression?
  • Attached logs, screenshots

Expected Results

Device record can be properly set

Actual Results

Topic id is removed from device record.

Steps to reproduce

  1. Register a device token
  2. Delete the record in DB
  3. Register the device token again
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants