Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Travis build on master #138

Closed
kinow opened this issue Jun 20, 2019 · 2 comments · Fixed by #141
Closed

Fix Travis build on master #138

kinow opened this issue Jun 20, 2019 · 2 comments · Fixed by #141

Comments

@kinow
Copy link
Member

kinow commented Jun 20, 2019

Found while reviewing #137 that the master branch is currently broken.

It should be some dependency, or maybe something in Travis. So whoever finds time to have a look and fix it, it'd be much appreciated (currently overseas with limited bandwidth, but will investigate it otherwise when I return home)

@YtvwlD
Copy link
Contributor

YtvwlD commented Jun 20, 2019

This just applies to Ruby versions 2.2 and 2.3. They aren't being supported, anymore.

Perhaps we should just remove them from the CI matrix and add 2.5 and 2.6 instead?

@kinow
Copy link
Member Author

kinow commented Jun 20, 2019

Perhaps we should just remove them from the CI matrix and add 2.5 and 2.6 instead?

Could be. Let's wait for others to chime in. Might drop a note to gitter later if there's no response here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants