On same deadline, items queued first have priority #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amcandio Please rebase on |
|
@notgull rebased! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 85.44% 86.22% +0.77%
==========================================
Files 13 15 +2
Lines 1876 2069 +193
==========================================
+ Hits 1603 1784 +181
- Misses 273 285 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@notgull any update on this? |
notgull
requested changes
Aug 22, 2024
| @@ -278,8 +278,11 @@ impl TimerWheel { | |||
| impl std::cmp::Ord for TimeoutData { | |||
| #[inline] | |||
| fn cmp(&self, other: &Self) -> std::cmp::Ordering { | |||
| // earlier values have priority | |||
| self.deadline.cmp(&other.deadline).reverse() | |||
| // earlier values have priority, on same deadline items queued first have priority | |||
There was a problem hiding this comment.
Please use proper capitalization and punctuation for comments.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple are registered at the same time, those registered first should have priority to make scheduling behavior easier to predict. I don't think this should be added as documented behavior to prevent users from depending on it.
Once nice to have follow up would be to start supporting custom prioritization as tie-breaker so users can define their own to handle tie-breaking. Right now users depend on tweaking expire timestamps to get same effect, which is not clean.