Use memfd_create on FreeBSD
#341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, fails to link on FreeBSD 12.1? Well, I guess that answers my question of when this was added. Not sure if there's any easy way to conditionally build based on FreeBSD version (would depending on features from the version of FreeBSD a project is compiled on be expected behavior?). |
|
Could we try to dynamically load memfd_create on FreeBSD? Or would that be overcomplicated? |
|
Would we need to FreeBSD also has a |
|
One question we could ask here is would a feature make sense to guard this from FreeBSD 12? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292.